Fix upb wire decoder accepting field number 0.#28781
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_952905580
branch
from
July 24, 2026 17:26
3c4f0e5 to
aea8eb6
Compare
copybara-service
Bot
changed the title
Reject field_number 0 tags in _upb_WireReader_SkipValueForceInline. Protocol Buffer wire format requires field numbers to be positive integers (1 to 536,870,911). Previously, _upb_WireReader_SkipValueForceInline lacked a (tag >> 3) == 0 check, allowing upb to accept and round-trip illegal field 0 tags in empty messages, unknown groups, and MessageSet items. PiperOrigin-RevId: 953447806
copybara-service
Bot
force-pushed
the
test_952905580
branch
from
July 24, 2026 17:50
aea8eb6 to
beb01ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix upb wire decoder accepting field number 0.
Reject field_number 0 tags in _upb_WireReader_SkipValueForceInline.
Protocol Buffer wire format requires field numbers to be positive integers
(1 to 536,870,911). Previously, _upb_WireReader_SkipValueForceInline lacked a
(tag >> 3) == 0 check, allowing upb to accept and round-trip illegal field 0
tags in empty messages, unknown groups, and MessageSet items.